ClassicPress / classicpress-seo

Classic SEO is the first SEO plugin built specifically to work with ClassicPress. A fork of Rank Math, the plugin contains many essential SEO tools to help optimize your website.
GNU General Public License v2.0
30 stars 10 forks source link

Composer discussion #148

Open viktorix opened 1 year ago

viktorix commented 1 year ago

This is a discussion focused on Composer usage in Classic SEO.

@xxsimoxx concerns:

@bahiirwa:

CSeo using composer to add the cmb2 plugin and thus needs the vendor folder in the repo. The same gets released unless the composer install is run again on release.

I'm not sure if we have original JS/CSS files. I have not seen them anywhere yet.

We can continue from this point here. So we can go back to the conversation in the future as needed.

bahiirwa commented 1 year ago
* if we get original CSS and JS set up npm and grunt as [here](https://github.com/ClassicPress-plugins/classicpress-seo/issues/138)

Agree. The issue listed for this is sufficient.

* vendor dir should not be in the repo but build when doing the release. Set up composer to create the zip file when doing a release

Of course the composer.json and .lock files handle the versions on install or export. However, to reduce the support as some users will download the plugin from the big green button above in the code section via GH. It is good to have all the necessary files available in here.

But it is a matter of no serious consequence, We can explore a build process for this in #140. For this option, we need to also document the development steps in #129 as well.

We can close this task here and add these as tasks to the respective issues already opened if we agree on way forward.