search

ClassicPress / site-www

Files for the site at www.classicpress.net
Other
2 stars 2 forks source link

Code display plugin on ClassicPress.net not working #1

Open klein-the-donkey opened 5 years ago

klein-the-donkey commented 5 years ago

Is the plugin broken? I can't see the button in the editor and the code that's normally displayed like: Schermafbeelding 2019-11-06 om 16 56 04 Is now displayed like: Schermafbeelding 2019-11-06 om 16 55 42

timbocode commented 5 years ago

As I recall, James had to remove the Crayon Syntax Highlighter plugin because it's not PHP7 compatible and was throwing numerous errors. @nylen should be able to confirm.

nylen commented 5 years ago

Yes, that's right. It's also pretty over-large for what it was doing. I'd be open to installing a lightweight replacement if you know of one.

johnalarcon commented 5 years ago

I've worked on the plugin to bring it to PHP 7 compatibility. Also, if you remove the 50 needless languages, it's much slimmer; this involves just removing the directories. For the ClassicPress blog, leaving in only html, xml, apache, php, sql, css, javascript, and json would probably cover every last need. Removing the extras is 1/3 of the plugin.

johnalarcon commented 5 years ago

I've built a slim and performant (250K footprint, 55K output) Syntax Highlighter plugin based on Prism. It still has one issue, but, may become a viable option for ClassicPress.net. Please give it a test-drive.

@nylen, I proposed a solution on this issue; is this the correct approach?