search

ClassicPress / site-www

Files for the site at www.classicpress.net
Other
2 stars 2 forks source link

Removes function cp_insert_twittercard_tags() from functions.php #11

Closed timbocode closed 4 years ago

timbocode commented 4 years ago

Twitter card info is currently generated using the cp_insert_twittercard_tags() in functions.php.

There are two issues with this:

  1. CPSEO also generates Twitter meta.
  2. The default twitter:image meta in cp_insert_twittercard_tags() is currently set to an image that does not exist. With this being hard coded, it is not so easy to change.

This PR removes the above function from functions.php and allows CPSEO to handle social media tags.

nylen commented 4 years ago

Perfect. I'm glad we have a "real" solution for this now. Thanks for the PR.

Updating the cache buster won't hurt anything, but for future reference this is only necessary when the externally enqueued JS or CSS files change.