search

ClassicPress / wp-cms-experimental

ClassicPress v2.0 can be found here: https://github.com/ClassicPress/ClassicPress-v2
https://github.com/ClassicPress/ClassicPress-v2
2 stars 0 forks source link

Branding: Replace logo files #34

Closed viktorix closed 1 year ago

viktorix commented 1 year ago

One thing I realized just now, we never changed the file names of logo files. They still say wordpress-logo.svg in ClassicPress. I don't know what copyright/trademark implications this may or may not have, but we should do it correctly and change file names this time.

wordpress-logo.svg|png

wordpress-logo-white.svg

w-logo-white.png

w-logo-blue.png

Misc. images

viktorix commented 1 year ago

@mattyrob if I modify CSS files inside wp-admin/css, how are minified versions generated?

For example, src/wp-admin/css/install.css and src/wp-admin/css/install.min.css.

mattyrob commented 1 year ago

Minified CSS and JS files are all created via grunt build and steps specified in Gruntfile.is

bahiirwa commented 1 year ago

One thing I realized just now, we never changed the file names of logo files. They still say wordpress-logo.svg in ClassicPress.

Related https://github.com/ClassicPress/ClassicPress-v1/issues/198 https://github.com/ClassicPress/ClassicPress-v1/issues/174 https://github.com/ClassicPress/ClassicPress-Design/pull/3 https://github.com/ClassicPress/ClassicPress/pull/189

I don't know what copyright/trademark implications this may or may not have, but we should do it correctly and change file names this time.

Worth considering with @KTS915 (GPL)

KTS915 commented 1 year ago

There are no copyright or trademark implications for the names of these files.

viktorix commented 1 year ago

Thanks @KTS915 @bahiirwa

My PR ClassicPress/ClassicPress-v1#237 includes renaming the files to properly use CP branding. If we don't want to make changes to 6 CSS/JS and 2 PHP files because of merge conflicts, I can change it back to what it was before. There are only eight files with file name changes.