search

ClassicPress / wp-cms-experimental

ClassicPress v2.0 can be found here: https://github.com/ClassicPress/ClassicPress-v2
https://github.com/ClassicPress/ClassicPress-v2
2 stars 0 forks source link

style(branding): ClassicPress logos #39

Closed viktorix closed 1 year ago

viktorix commented 1 year ago

Replaced WordPress logo files with ClassicPress and changed file names across relevant files. Closes #34

Verified with grep command several times that all logo file names have been replaced/changed.

viktorix commented 1 year ago

@xxsimoxx wp-login.php does not have a logo image, only login.css, which was updated. Could you please either do a hard refresh or try incognito mode to see if it's a cached login.css?

wordpress-logo.svg was replaced with classicpress-logo.svg in login.css.

xxsimoxx commented 1 year ago

@viktorix I see an error in the console about missing files. I checked out the PR and when you reload switching to main shows the WP logo, switching to the PR branch there is no logo and an error.

viktorix commented 1 year ago

@xxsimoxx thanks, let me do more digging.

viktorix commented 1 year ago

@xxsimoxx It was the minified files. I did not change them because they are generated during build. Which also means we need to delete minified files from src. Please, set define( 'SCRIPT_DEBUG', true ); while testing src files. This will switch everything over to original CSS/JS files.