ClassicWoWCommunity / cata-classic-bugs

This is a place for Cataclysm & Wrath of the Lich King Classic bug reports and research
66 stars 6 forks source link

[BUG] Rupture extensions (Subtlety Rogue) + Rip extensions (Feral Druid) can munch ticks #1354

Open corymonroe opened 6 months ago

corymonroe commented 6 months ago

1. Current Behavior

1.1. Description

Rupture sometimes does not tick for the full duration when refreshed in Subtlety specialization. I am not certain, but I think it may fall off early when it is refreshed either in shadow dance or while expose weakness debuff is present on the target.

1.2. How to Reproduce

       1. Get a 5 cp rupture up on a target dummy
       2. use shadow dance
       3. use ambush to 5 cp
       4. use eviscerate to refresh the rupture
       5. let the rupture fall off
       6. when I perform the above steps a high percentage of ruptures disappear before the last 1 or 2 ticks

1.3 Source Material

https://github.com/JamminL/cata-classic-bugs/assets/3914260/a3df7ec4-e36c-4cf3-b2a0-d7bb96352ebb

2. Expected Behavior

2.1. Description

Rupture should tick for the entire duration. Note, in other rogue specializations I am unable to get a rupture to fall off early.

2.2 Source Material

N/A

corymonroe commented 6 months ago

Edited to make a bit more clear that it doesn't not tick for the entire duration of the spell and added a video

Korbrawr commented 5 months ago

I've noticed that feral druids have a similar issue with their glyph of bloodletting, which extends rip by 2 seconds (to a max of 6 seconds) when using shred or mangle in cat form. In some circumstances, rip will fall off before its final tick.

How to reproduce

       1. Cast rip on a target dummy
       2. Immediately shred once
       3. Wait until rip has less than 1 second remaining
       4. Shred twice
       5. Rip will fall off at 1 second remaining exactly, skipping the final tick

https://github.com/JamminL/cata-classic-bugs/assets/104960823/c0030a99-27a1-4511-88f1-0c60ddfb7ea1

Log: https://classic.warcraftlogs.com/reports/6aNnjJg3FWRZYrBh#fight=last&pins=2%24Off%24%23244F4B%24expression%24ability.name%3D%22Rip%22%20or%20ability.name%3D%22Shred%22&view=events

SimonBpvp commented 4 months ago

I believe that every talent/spell that refreshes dots is currently bugged in some way. Something tells me it’s related to haste or a more powerful spell is already active mechanic, but that’s guessing. Or it could be related to the Cata mechanic which protects dot ticks from being munched when the player re-applies the dot.

NerdEgghead commented 3 weeks ago

In case it helps debug this issue, the temporary Rend change that got implemented on live (and soon reverted) also exhibited a similar effect while it was active: https://classic.warcraftlogs.com/reports/DBNfHTR3h96JqjL4#fight=4&type=damage-done&source=11&view=events&pins=2%24Off%24%23244F4B%24expression%24ability.name%3D"Mortal%20Strike"%20or%20ability.name%3D"Rend"%20

Kethryllia commented 2 weeks ago

This looks like a bug that we're working on in SOD. I've copied that bug to Cataclysm as well.

caten7 commented 1 week ago

The bug, I believe is the following: When you reapply Rupture between two ticks, it will (for whatever goofed up reason) subtract the time between the most recent tick and the point of reapplication from the total duration of Rupture. To illustrate:

Rupture applied: 00:04.519 Tick 1: 00:06.451 Tick 2: 00:08.527 Tick 3: 00:10.534 Tick 4: 00:12.528 Rupture reapplied: 00:13.896 Tick 5: 00:14.431 Rupture expired: 00:28.520 Should have expired: 00:29.896

Time between 4th tick and reapplication is 1.368s, time between expire and when it should have is 1.376s. Obviously due to combat log batching the timer isn't perfect, but I wrote a WA that shows what I believe to be the correct Rupture duration based on the diagnosis I made above, and it has been very accurate so far after dummy testing.

Edit: Here is a video, https://www.youtube.com/watch?v=VAby8uSPPO0

Beakachu commented 2 days ago

The bug, I believe is the following: When you reapply Rupture between two ticks, it will (for whatever goofed up reason) subtract the time between the most recent tick and the point of reapplication from the total duration of Rupture. To illustrate:

Rupture applied: 00:04.519 Tick 1: 00:06.451 Tick 2: 00:08.527 Tick 3: 00:10.534 Tick 4: 00:12.528 Rupture reapplied: 00:13.896 Tick 5: 00:14.431 Rupture expired: 00:28.520 Should have expired: 00:29.896

Time between 4th tick and reapplication is 1.368s, time between expire and when it should have is 1.376s. Obviously due to combat log batching the timer isn't perfect, but I wrote a WA that shows what I believe to be the correct Rupture duration based on the diagnosis I made above, and it has been very accurate so far after dummy testing.

Edit: Here is a video, https://www.youtube.com/watch?v=VAby8uSPPO0

Can you please share this weakaura? Until this bug is fixed you kind of need something like this to play sub.

In a 7/7 heroic clear yesterday I estimate I got hit by this bug approximately 15 times. Now sub dps is becoming mainstream, the impact of this bug is becoming higher than it was in T11 where sub was niche.