ClassicWoWCommunity / cata-classic-bugs

This is a place for Cataclysm & Wrath of the Lich King Classic bug reports and research
64 stars 6 forks source link

[BUG] exhaustion / sated doesn't reset on death #1430

Closed SimonBpvp closed 1 month ago

SimonBpvp commented 2 months ago

1. Current Behavior

1.1. Description

the Bloodlust / Heroism debuff doesn't reset on death. Time warp still resets on death as normal. Only shaman version is bugged

1.2. How to Reproduce

       1. lust
       2. kill the player
       3. res

1.3 Source Material

https://clips.twitch.tv/AntediluvianApatheticHamburgerRiPepperonis-Yw9VSgW3eLxDerN0

2. Expected Behavior

2.1. Description

dying should clear these debuffs

2.2 Source Material

https://www.wowhead.com/cata/spell=57724/sated

Screenshot 2024-06-23 at 02 16 25
AidanZMoon commented 2 months ago

This a bug, but it's bugged in the opposite way.

Time Warp's debuff should not go away when you die.

This protection was put in place in wrath classic when cooldowns were made to reset on encounter end. OG Cataclysm and OG Wrath did not have a cooldown reset to my knowledge. T14 5.0 was when it first came in for long cooldowns (could be wrong?).

So this is to prevent you doing a fight, dying during an intermission on purpose, taking a soul stone/reincarne and then getting a second lust in the fight.

Although it doesn't match OG Cata, OG Cata did not have cooldown resets. So it requires a different approach. And if for some reason I'm wrong on this, and cooldowns being cleared did exist in Cata - I don't think having people die on purpose to parse is a good idea to allow.

So we'll make it so Time Warp doesn't allow this.

SimonBpvp commented 2 months ago

Cool, I will just say first I think you are not correct about how it worked on original cata, below is a clip of someone dying on Ultraxion HC, and he loses the buff. HOWEVER, as you say in 2024 with parses and everything, you should probably do whatever you think is best with something like Heroism, as long as you make it consistent between mage version and shaman version of course. I would be reasonably happy with the different approach that you refer to and I think it would be justifiable. Although it does affect RBG games a bit but imagine caring about RBGs in 2024.

Ultraxion HC: https://www.youtube.com/watch?v=Rr4YyKaU7Ik&t=357s

RBGs: https://youtu.be/CIIkgd7juWo?feature=shared&t=162

AidanZMoon commented 2 months ago

I'm not correct about how it worked in Original Cataclysm?

My impression is in OG Cata if you died you lost all types of sated/exhausted etc. But OG Cata did not have Cooldown reset on Encounter_End in PvE.

Is this incorrect? Maybe I wasn't clear.

Clearing debuff on Death = OG Cata Resetting Cooldowns on Encounter end = Classic Cata Having both causes a conflict that didn't exist in OG Cata. So a modern solution is to extend the Classic Wrath fix to Classic Cata and have Mage Time Warp and Core Hound Primal Rage debuffs not be removed on death, but do clear on encounter_end when the fight is resolved.

SimonBpvp commented 2 months ago

You're completely correct there, I think I have misunderstood you, sorry. Now I understand.

Will it be that the buff persists through death in classic then?

SimonBpvp commented 2 months ago

I'll just note that in RBGs the bloodlust is a very important buff for team fights, and a key element in RBG games was always to pop a second bloodlust after you wiped. This gives the losing team an advantage when you can have lust in 2 consecutive fights and it's usually the only thing that allows you to retake for example Waterworks after you lose the first fight. That was the thinking behind of my original report, that right now only Time Warp is letting you do this.

edit: But players can adapt to however it works in future as long as the spells aren’t buggy and inconsistent.

SimonBpvp commented 2 months ago

the change is live I think.