[BUG] Hand of Guldan/Curse of Guldan not working

kollariss commented 4 months ago

### 1. Current Behavior

#### 1.1. Description

Hand of guldan spell applies aura that increases crit chance against that target by any warlocks demon. Currently it appears to only impact the special attack of pets specifically, not other demons and or other attacks/abilities.
Additionally it impacts the special abilities of all warlocks, that is it buffs also afflictions shadow bite crit chance by 10% or destructions imp firebolt.

#### 1.2. How to Reproduce

       1. Cast Hand of Guldan
       2. Attack with pet / Use Doomguard / Spawn ebon imp
       3. Look for crits

#### 1.3 Source Material

Pet dummy test without Hand of Guldan Demo https://classic.warcraftlogs.com/reports/xPFL2MpDhcdvWjCH#fight=last&type=damage-done&source=1&ability=-691
Pet dummy test with Hand of Guldan https://classic.warcraftlogs.com/reports/dAJkHMNctTprwCWF#fight=last&type=damage-done&source=4&ability=-691
Pet dummy test with Hand of Guldan and Affliction pet https://classic.warcraftlogs.com/reports/dAJkHMNctTprwCWF#fight=last&type=damage-done&source=4&ability=-691

The above mentioned links prove that autoattacks are not impacted by the 10% increase and also affliction warlocks shadowbites are impacted by the Hand of Guldan aura. As for the other claims, i derive them from the data on warcraft logs. The base premise is that we need large enough sample size of data from logs where only 1 warlock is present (demo or affli) and compare the results. Due to the nature of the 10% crit debuff, the following observations are expected to be noticeable in the data from warcraft logs:

Pet auto attack of demo locks is supposed to be around 10% higher for demo locks.
Special ability crit should be around 10% higher for demo locks.
Doomguard crit should be around 10% higher for demo locks.
Ebon imp crit should be around 10% higher for demo locks.
Due to stat priority, crit rating of affli warlocks in general is higher so the gap should be somewhat smaller.
Samples are outside of controlled environment, however due to the fact that the debuff increases crit by 10%, it should be sufficient to prove whether it works or not even if the observed gap is not exactly 10%.

Affliction logs:

Demo logs:

I think based on the data presented above, its safe to make following conclusions:

Autoattack is not buffed by curse of guldan
Special ability of pet is buffed by curse of guldan; affliction/destruction benefits from it as well
Doomguard is not affected by curse of guldan
Ebom imp is not affected by curse of guldan.

### 2. Expected Behavior

The aura of Curse of Guldan is supposed to buff any warlock demon. Right now it impacts only special ability of the pet.
Is the "any warlock demon" part tied to all warlock pets or only the demo warlock demons. (clarification of the tooltip needed, cant find any source material for what was intended with this, cant find any mentions of this buffing other specs as well on elitist jerks/other resources). I suspect it is unintended for Curse of guldan to buff destro/affli pets.

#### 2.1. Description

Any demon of the demonology warlock(?) should have increased 10% crit chance against targets afflicted by curse of guldan.

#### 2.2 Source Material

https://www.wowhead.com/cata/spell=86000/curse-of-guldan

Artemishowl commented 4 months ago

Valid issue, ticket created

malvanis commented 2 months ago

This is two logs I had as destro in the same gear. One with a demo lock and the other without. My imp's crit chance can be seen at ~10% higher on the raid with the demo lock on overall damage to bosses as well as individual boss fights: https://classic.warcraftlogs.com/reports/compare/ZvC7R9JGxg1nmky8/MtHkvAf7L6hPj1gG#type=damage-done&boss=-2&difficulty=0&wipes=2&source=5,15

ClassicWoWCommunity / cata-classic-bugs

[BUG] Hand of Guldan/Curse of Guldan not working #1463