[BUG] The trinket Vial of Shadows is missing BonusCoefficientFromAP

[RobFalfa]

1. Current Behavior

1.1. Description

Vial of Shadows is missing the spell effect BonusCoefficientFromAP in the database. Heroic: https://wago.tools/db2/SpellEffect?build=4.4.1.56574&filter[SpellID]=109724&page=1 Normal: https://wago.tools/db2/SpellEffect?build=4.4.1.56574&filter[SpellID]=107994&page=1

2. Expected Behavior

2.1. Description

Similar trinket Bone-Link Fetish has this set. https://wago.tools/db2/SpellEffect?build=4.4.1.56574&filter[SpellID]=109754&page=1

[hillerstorm]

I don't think this is a bug https://wowpedia.fandom.com/wiki/Vial_of_Shadows

Patch 4.3.2 (2012-01-31): Vial of Shadows damage (Lightning Strike) has been reduced to approximately one-third of previous damage. However, it will now trigger approximately 3 times as often. This is intended to keep overall DPS the same while reducing burst damage, especially in PvP.

CD was reduced from 27s to 9s and AP scaling was removed. I guess the pvp-nerf wasn't needed for the strength version 🤷

Adding this to the sim with a 9s cd and no AP scaling sims within margin of error of a 27s cd with the scaling from wowpedia so it feels correct.

[RobFalfa]

From my understanding SimC had this set to 33,9%/30%/26,6% after the change but that might have been incorrect. The spell power coefficient they had set on cunning of the cruel seems to match the classic db.

[hillerstorm]

From my understanding SimC had this set to 33,9%/30%/26,6% after the change but that might have been incorrect. The spell power coefficient they had set on cunning of the cruel seems to match the classic db.

Actually yea, I tried to look back at old simc commits and wowpedia history, the damage-range was way higher before the change so the ap scaling should probably still be there, my bad!

One thing to note though is that the numbers in simc are approximations it seems like:

else if ( name == "vial_ofshadows" ) e = ( heroic ? "OnAttackHit-5682+33.90Physical_45%_9Cd_NoDodge_NoParryNoBlock" : lfr ? "OnAttackHit-4460.5+26.60Physical_45%_9Cd_NoDodge_NoParryNoBlock" : "OnAttackHit-5035+30.00Physical_45%_9Cd_NoDodge_NoParry_NoBlock" ); // ICD, base damage, and ap coeff determined experimentally on heroic version. Assuming dbc has wrong base damage. Normal and LFR assumed to be changed by the same %

[hillerstorm]

yea the coef was higher before the nerf as well if we're to trust old wowhead comments :D

[hillerstorm]

Another source stating it scales with attack power (and this time it's actual patch notes): https://www.bluetracker.gg/wow/topic/us-en/4023884-patch-43-hotfixes/ Under January 9:

• Vial of Shadows proc damage should now be increased by ranged attack power for hunters.