ClassicWoWCommunity / cata-classic-bugs

This is a place for Cataclysm & Wrath of the Lich King Classic bug reports and research
62 stars 6 forks source link

[BUG] Spirit Weapons talent not properly reducing threat for spells #168

Closed Wumblesnarf closed 1 year ago

Wumblesnarf commented 2 years ago

1. Current Behavior

1.1. Description

The enhancement shaman talent Spirit Weapons is not currently applying it's threat reduction to all damage, only to melee attacks.

1.2. How to Reproduce

      1: learn the talent Spirit Weapons
      2: have an addon or macro to display threat values
      3: use any damage spell (test was done with earth shock)

1.3 Source Material

image image

2. Expected Behavior

2.1. Description

Spirit Weapons should be reducing all threat, not just threat from melee attacks. The earth shock in the screenshot that hit for 133 should have done ~93 threat, not 133

2.2 Source Material

the tooltip in the first attached image official 3.1 patch notes (archive): https://web.archive.org/web/20090417063425/http://www.worldofwarcraft.com:80/patchnotes/

Wumblesnarf commented 2 years ago

following up on this after noticing the tooltip mentions all threat generated rather than just from damage, more testing shows that heal spells seem to be correctly benefiting from the threat reduction image image

Wumblesnarf commented 1 year ago

seems to have been fixed at some point between then and now, just wasnt retested until now