[BUG] Omen of Clarity - Wrong Proc Chance for 3s Healing Touch Cast (PTR Build# 45043)

[Frankensteak]

1. Current Behavior

1.1. Description

A test of 3 second Healing Touch casts resulted in 1442 casts and 126 Omen of Clarity procs, a proc rate of 8.74%.

1.2. How to Reproduce

       1. Be a cool Druid
       2. Remove all haste from gear and talents
       3. Go into RFC
       4. Start logging
       5. Get aggro
       6. Cast HT 1,000 times
       7. Review the proc rate in the logs

1.3 Source Material

https://www.warcraftlogs.com/reports/YzrTwWfdtH7nBA8X/#boss=-3&difficulty=0 Casts tab for number of Healing Touch casts Buffs tab for number of OoC procs (Clearcasting buff)

2. Expected Behavior

2.1. Description

Following the formula referenced by Aggrend here: https://github.com/JamminL/wotlk-classic-bugs/issues/66#issuecomment-1182017571 The proc chance for a 3s HT cast should be (3.5/(60/3))*0.67 = 11.725%. The number of casts in the test gives a confidence of 99.99% that an 11.725% proc chance is not possible.

2.2 Source Material

https://stattrek.com/online-calculator/binomial for probability confidence

[Frankensteak]

@yurpcraft why the Research Needed tag? I feel like thousands of casts and 99.99% confidence is adequate testing. Is it regarding sourcing the ooc proc chance formula?

[yurpcraft]

@Frankensteak given Aggrend's comment on #66 and further omen work done in #138, I believe this is "research needed" on the blizz side to confirm this is the expected behavior, or if the comment was incorrect. Either way, it all seems related to OOC proc rates

[Frankensteak]

Awesome, thanks for the clarification.

[JamminL]

Fixed as of build 3.4.0.45264

[Frankensteak]

@JamminL Just did a test on beta build 3.4.0.45264. 3s HT testing (no haste on gear or talents) resulted in 25 procs over 316 casts. 7.91% proc rate and 98.92% confidence the proc chance is not 11.725%

https://www.warcraftlogs.com/reports/bpnKDz8JXgdCmk9V/#boss=-3&difficulty=0

Would you mind going into what was fixed, and if the formula Aggrend suggested in #66 is accurate?

[caccavale]

Not sure why this was closed. Per Frankensteak's work, the proc chance does not seem to be correct.

[caccavale]

Some more data pertaining to instant casts:

538 rejuv casts (no haste, 1.5s GCD) 39 procs 7.25% proc rate

https://www.warcraftlogs.com/reports/bMC91cK3dmQHhPfp/#boss=-3&difficulty=0

No good fit: Casted spell odds: 3.5/(60/1.5)x0.67 = 5.86% proc chance (high end of probability, but possible)

Casted spell odds ignoring 33% failure script: 3.5/(60/1.5) = 8.75% proc chance (low end of probability, but possible)

Instant spell odds: 3.5/(60/1.5)x0.076 = 0.665% proc chance (mathematically impossible)

[Frankensteak]

Tested HT with glyph of healing touch

419 1.5s HT casts ( no haste on gear or talents) 18 ooc procs 4.3% proc rate https://www.warcraftlogs.com/reports/d9vJGapqAtHw23Xg/#boss=-3&difficulty