ClassicWoWCommunity / cata-classic-bugs

This is a place for Cataclysm & Wrath of the Lich King Classic bug reports and research
64 stars 6 forks source link

[BUG] Genesis not properly affecting Hurricane and not affecting Starfall #371

Open zacjen opened 2 years ago

zacjen commented 2 years ago

1. Current Behavior

1.1. Description

Genesis is supposed to increase damage done by periodic damage by 5%

1.2. How to Reproduce

       1. Have 0/5 Genesis, use Hurricane and Starfall. Record damage. 
       2. Have 5/5 Genesis, use Hurricane and Starfall. Record damage. 
       3. Compare the damage, be disappointed. 

1.3 Source Material

https://classic.warcraftlogs.com/reports/QfaknTYNRc4JrHXv#boss=-3&difficulty=0&type=damage-done&ability=48466&view=events

2. Expected Behavior

2.1. Description

The damage increases as seen in the logs from 659 -> 684, a 3.7% increase as opposed to the expected 5% increase. Starfall should have also seen a 5% damage increase based on the pictures below.

2.2 Source Material

hurricane starfall

Both Hurricane and Starfall are described as periodically trigger spells, but Genesis only seems to affect Hurricane and not Starfall.

vigo2 commented 1 year ago

"By rights", Genesis would only apply to periodic damage, and neither Hurricane nor Starfall would be affected (since neither of them deal periodic aka tick damage). It just happens to have Hurricane (and Tranquility) on it's "Apply Aura: Modifies Damage/Healing Done" list of spells, probably because both used to deal periodic damage back in Vanilla/Classic.

For me, Genesis correctly increases damage by 5%: Screenshot 2022-12-06 at 22 23 53

Genesis and Gale Winds stack additively, so I guess you had the latter talented (135% / 130% = 103.84%). Your log doesn't allow checking for spellpower changes, it's showing 0 spell power throughout.