search

Classiq / classiq-library

The Classiq Library is the largest collection of quantum algorithms, applications. It is the best way to explore quantum computing software. We welcome community contributions to our Library 🙌
https://platform.classiq.io
MIT License
282 stars 98 forks source link

Arithmetic ipynb #112

Closed AbdullahKazi500 closed 1 month ago

AbdullahKazi500 commented 1 month ago

This notebook defines and synthesizes a quantum model that performs a simple arithmetic operation on quantum numerical variables (QNum). It then optimizes the quantum circuit based on depth while constraining the maximal width to specific numbers of qubits (9 and 12). The synthesized quantum circuits are executed, and the results are printed. Additionally, the quantum models are saved to files and can be seen in the classiq platform fixes #36

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

AbdullahKazi500 commented 1 month ago

@TomerGoldfriend Hi tomer can you review my PR for #36 I was not able to add it directly to the directory It can be shifted to the directory

TomerGoldfriend commented 1 month ago

Dear @AbdullahKazi500 , you should have modify the already existing notebook (also, your new notebook has a non-indicative name). In addition, there are two major requirements that are not fulfilled by the PR: 1. you did not include the relevant qmods, 2. you did not compare to the classical result.

AbdullahKazi500 commented 1 month ago

@TomerGoldfriend thanks for the review

TomerGoldfriend commented 1 month ago

Sure @AbdullahKazi500 , thank you again for your interest and sorry it did not work out this time.