search

Classiq / classiq-library

The Classiq Library is the largest collection of quantum algorithms, applications. It is the best way to explore quantum computing software. We welcome community contributions to our Library 🙌
https://platform.classiq.io
MIT License
282 stars 98 forks source link

HW-aware synthesis capability #116

Closed Qubit1718 closed 1 month ago

Qubit1718 commented 1 month ago
  1. Created two different HW-aware synthesis preferences configurations that implements a multiple control-x (MCX) logic.
  2. Used two different devices and simulators.
  3. Optimizes the 'cx' gate count.

This will close the issue #41

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Qubit1718 commented 1 month ago

Hi @orsa-classiq,

Thank you so much for taking your time and reviewing the PR. I will work on these comments and update the notebook as soon as possible :))

Qubit1718 commented 1 month ago

Hi @orsa-classiq,

I made all the required changes. Can you please check now? Please let me know if you still find anything inappropriate. Hope to hear from you soon :))

orsa-classiq commented 1 month ago

@Qubit1718 That's great. There is just a small thing with the plotting that I was probably not enough clear about. I want it to be plotted (e.g. with matplotlib).

Qubit1718 commented 1 month ago

Can you please be a bit more specific, @orsa-classiq ? Should I plot the output of CX gates against the depth? or should I plot the grid connectivity using matplotlib?

orsa-classiq commented 1 month ago

Can you please be a bit more specific, @orsa-classiq ? Should I plot the output of CX gates against the depth? or should I plot the grid connectivity using matplotlib?

plot the grid connectivity :)

Qubit1718 commented 1 month ago

Can you please be a bit more specific, @orsa-classiq ? Should I plot the output of CX gates against the depth? or should I plot the grid connectivity using matplotlib?

plot the grid connectivity :)

Thanks for the quick reply, I will work on it and update the file soon. Thanks :))

Qubit1718 commented 1 month ago

Hi @orsa-classiq, The new commit includes the connectivity graphs using matplotlib and networkx. Can you please review it? I look forward to seeing the PR merged :))

Qubit1718 commented 1 month ago

Hi @orsa-classiq,

Thanks for approving the changes. Could please also let me know if there anything more that i need to do from my end to get the PR merged? And the next steps if any.

orsa-classiq commented 1 month ago

Sorry, I approved and then realized there are additional changes needed:

  1. Commit the notebook with the outputs (the graphs output cells are missing)
  2. put the notebook in a directory with the same name, i.e. in community/basic_examples/hw_aware_synthesis
  3. commit also the .qmod and .synthesis_options files that are created by the notebooks, within the same directory

Then I will take care for the merge

Qubit1718 commented 1 month ago

Hi @orsa-classiq ,

Completed the required changes. Please go through them and let me know if there are any additional changes required. Thanks!