Classy-Closets / Snap-Updates

Snap-Updates
6 stars 0 forks source link

2D Views Plan View - Top Shelf & Countertops #242

Closed TedCC1209 closed 3 years ago

TedCC1209 commented 3 years ago

Top shelf appears to show up in the plan view of 2D Views while countertops do not seem to show. Can we have both show up on the plan view but have them in gray rather than black?

2D Views.pdf

Thanks,

Ted

nailsonlandim commented 3 years ago

Hi @TedCC1209 @sarahhightower @kategodfrey

Found out the bug that caused that. Now countertops will be correctly displayed.

The problem was caused (my bad) because when unlinking cleats I did not deselect any existing selected object, and the way Blender works it needs to set an object as active to unlink it from a different scene (in this case a 2D view).

So as a note for any developer in the future, make sure you have deselected objects on scene previously

bpy.ops.object.select_all(action='DESELECT')

Available together with 241: https://github.com/nailsonlandim/SNaP-Dev/tree/issue_%23241-exp-annotation-hash-mark

TedCC1209 commented 3 years ago

EDIT: none of the countertop lines seem to be showing up still.

Also, can we have topshelf and countertop lines on the plan view be a medium to dark gray rather than black? They still look black to me.

2D Views.pdf

label test.pdf

nailsonlandim commented 3 years ago

Sorry, I`ll add the Countertops just as the Topshelves are added.

About the color I`ll check that with Antonio.

nailsonlandim commented 3 years ago

Hi @TedCC1209,

I've added the Countertop at the Plan View,

image

Tell me what you think.

Available at: https://github.com/nailsonlandim/SNaP-Dev/tree/issue_%23241-exp-annotation-hash-mark

TedCC1209 commented 3 years ago

Thanks Nailson, I am seeing the CTs on the plan view now.

Can you tell me what the dotted lines are in your example? Are those uppers? I think we kept those as solid lines, no?

nailsonlandim commented 3 years ago

Can you tell me what the dotted lines are in your example? Are those uppers? I think we kept those as solid lines, no?

Yes, they are uppers. In fact, makes sense to be solid lines but as far as I remember they were dashed in this situation.

kategodfrey commented 3 years ago

@TedCC1209 This is what I got: Screenshot 2020-12-29 112044

kategodfrey commented 3 years ago

I just see issues in the fine details. For the countertop issue specifically:

1) In the plan view, the countertop doesn't connect on the left side.

Other small issues:

2) The closet components are layered when there are uppers and lowers. 3) The ceiling height is hidden under the left corner (Job Name, Job Number, Install Date...)

kategodfrey commented 3 years ago

lines

TedCC1209 commented 3 years ago

Can you tell me what the dotted lines are in your example? Are those uppers? I think we kept those as solid lines, no?

Yes, they are uppers. In fact, makes sense to be solid lines but as far as I remember they were dashed in this situation.

Alright, well let's make them solid please. Also please let me know what you're thinking for fixes on what Katie pointed out and an ETA if possible. Thanks, Ted.

nailsonlandim commented 3 years ago

Hi @kategodfrey

  1. In the plan view, the countertop doesn't connect on the left side.

That seems a faster fix. probably just a tweak on how the countertop is "positioned" on PV. (ETA, 1-2h, today) 1-2 PM Arizona Time

The closet components are layered when there are uppers and lowers.

Are you referring to the text? image

The ceiling height is hidden under the left corner (Job Name, Job Number, Install Date...)

I can adjust the 2D view image handling to use the canvas until right below the texts. (ETA, 3-4h, today) 5-6 PM Arizona Time

I would also appreciate it if you could send the file, I am not that creative (for closet designs), and if you have any interesting file/project you want to share I thank you!

nailsonlandim commented 3 years ago

Hi @kategodfrey ,

image

These glitches are due to the blender render (specifically Freestyle renderer). I think @AntonioGloria could explain it better.

Unfortunately, we can't do much to fix it. unless Antonio has something in his hat.

kategodfrey commented 3 years ago

@nailsonlandim

The closet components are layered when there are uppers and lowers.

Are you referring to the text? image Yes, the text is stacked and hard to read

The ceiling height is hidden under the left corner (Job Name, Job Number, Install Date...)

I can adjust the 2D view image handling to use the canvas until right below the texts. (ETA, 3-4h, today) 5-6 PM Arizona Time Great thank you! I would also appreciate it if you could send the file, I am not that creative (for closet designs), and if you have any interesting file/project you want to share I thank you! Yes I can do that for you. I will create a subfolder in the one I shared with you the other day that will have closet designs. I have put my file in it of the project above, it's called "countertest."

https://drive.google.com/drive/folders/1QxfCLpfCkLOux5RXor4cWOdUw9YZ1acN?usp=sharing

nailsonlandim commented 3 years ago

Hi @kategodfrey

I need permission to access the folder. Thanks!

jagg87 commented 3 years ago

Hi @kategodfrey,

These glitches are due to the blender render (specifically Freestyle renderer). I think @AntonioGloria could explain it better. Unfortunately, we can't do much to fix it

@nailsonlandim is correct. This glitch is related to orthographic views and to the fact that many objects are meeting or intersecting at those spots.

kategodfrey commented 3 years ago

@nailsonlandim @AntonioGloria Ok that makes sense. It's no big deal!

and @nailsonlandim can you give me your email address so I can give you access?

nailsonlandim commented 3 years ago

@nailsonlandim @AntonioGloria Ok that makes sense. It's no big deal!

and @nailsonlandim can you give me your email address so I can give you access?

nailson.landim@bairesdev.com

kategodfrey commented 3 years ago

Great. You should be able to open it now!

nailsonlandim commented 3 years ago

Hi @kategodfrey

I fixed the issue on countertops. Now it shows correctly it.

EDIT: available at: https://github.com/nailsonlandim/SNaP-Dev/tree/issue_%23241-exp-annotation-hash-mark

kategodfrey commented 3 years ago

I can see the line now connects👍, but the list of closet components are still stacked in that third opening with the hamper.

image

kategodfrey commented 3 years ago

And we want that dotted line to be solid.

nailsonlandim commented 3 years ago

I can see the line now connects👍, but the list of closet components are still stacked in that third opening with the hamper.

image

And we want that dotted line to be solid.

I am working on it right now. As soon as I have it I'll push and tell you. I wanted to push it so you can have it faster. Sorry for any inconvenience,

kategodfrey commented 3 years ago

All good! Just didn't want to forget about it. Thank you!!

nailsonlandim commented 3 years ago

Hi @TedCC1209

I've fixed the PV labels issue.

PV_labels

It's available at https://github.com/nailsonlandim/SNaP-Dev/tree/issue_%23241-exp-annotation-hash-mark

At this very moment, Antonio and I are working on the solid lines.

Correct me if I am wrong, but for now, those dashed lines mean that the upper is overlapping the countertop and that's not the case.

TedCC1209 commented 3 years ago

Correct me if I am wrong, but for now, those dashed lines mean that the upper is overlapping the countertop and that's not the case.

Yes they are overlapping but from this view the TS would be in front of/on top of the CT

nailsonlandim commented 3 years ago

Hi @TedCC1209 @kategodfrey

The reason why dashed lines occur is that at Plan View the upper is positioned inside the other opening. And right now the TS is under the openings.

image

So the rendered image is this:

image

If I manually place the CTOP and uppers... (an experiment)

image

The rendered image is this:

image

Is there any particular reason to create these cages like this @RyanMDev @ClassyTeddy ?

sarahhightower commented 3 years ago

Tested and all of the above mentioned issues (besides the dotted lines and overlapping height/text) appear correctly in my test.

Test Image