Open TedCC1209 opened 3 years ago
@sarahhightower please take a look at this issue and let us know if you see any issues. Below are a few screenshots from Antonio.
This feature is available here: https://github.com/nailsonlandim/SNaP-Dev/tree/issue_%23250-label-locks-db-jewelry-drawers
@TylerStandage and @AntonioGloria. This looks good to me! Full disclosure: I've only added locks to drawers before so I hope I'm not missing anything important here. @TedCC1209?
I was able to reproduce what @AntonioGloria did and I think it works well. I was able to produce some collisions of text throughout, partly because I decided to make it a very busy design that wouldn't likely happen in the real world.
My view is this one is good to go unless Ted has a change he wants to see. There may be some work we can put in at a later date around how we place the text in the 2D views, but I think this will be a longer term effort. For now this is quite functional.
I think this is good to go, thank you @AntonioGloria !
We need to label locks (and whether they are top or side locks--just say "Top Lock" or "Side Lock") and double jewelry drawers ("Db Jwlry"). Not sure where the best place is to put the labels but do your best--I would say put it on the left side of the drawer face but if you have a side lock and a double jewelry drawer in the same drawer the space could be limited. Let me know if you're struggling on where to put the label and we can brainstorm.
Note: When we create the regular jewelry drawer option (which will add a jewelry drawer insert to the drawer box) we will need a label added for that as well, but we can't add it now since the option does not yet exist.