search

Classy-Closets / Snap-Updates

Snap-Updates
6 stars 0 forks source link

2D Views: Flat crown #257

Open TedCC1209 opened 3 years ago

TedCC1209 commented 3 years ago

For flat crown built to ceiling, we need to label how many holes down the top KD is placed if the top KD is lowered:

Flat Crown Top Holes Down

When a top KD is lowered one or two holes, a second line should be added to the Flat Crown label (which currently gives the height) and the second line should say "Top KD down 1 hole" or "Top KD down 2 holes"

TedCC1209 commented 3 years ago

Currently if the "Extend to Ceiling" option is selected the label will still just put the height of the FC that was in the height prompt previously, so when you get to addressing this issue you will also have to need to account for the extend to ceiling option when displaying the FC height.

jagg87 commented 3 years ago

Hi @TedCC1209, @sarahhightower and @kategodfrey, I have added the labeling features to the Flat Crown labels. fc_01 fc_02 fc_03 fc_03_4in Available here: https://github.com/nailsonlandim/SNaP-Dev/tree/issue_%23257-label-flat-crowns

TedCC1209 commented 3 years ago

@sarahhightower @kategodfrey Please see my email to you explaining the why's and how's of bringing the top KD down a hole when flat crown is to the ceiling. Then please test this branch and let us know what you think. @AntonioGloria can you get this branch up to speed with the recent updates please?

Thanks, Ted

jagg87 commented 3 years ago

Hi @TedCC1209, @sarahhightower, and @kategodfrey, I have updated this branch with the other updates. It's ready to test.

sarahhightower commented 3 years ago

Looks great to me! If you'd like me to be knit-picky I'd say that I prefer that the wall length and flat crown notation not be stacked so closely together as it looks more crowded than it needs to be. But that's just a personal preference.

Screenshot 2021-02-05 093651

TedCC1209 commented 3 years ago

@sarahhightower what would you think if the entire label was placed where the "Top KD Down 2 Holes" is currently located?

Alternatively, what if there was no hashmark and the "Flat Crown 5.77"" was just centered on the flat crown itself?

sarahhightower commented 3 years ago

I just went and asked Chris Johnson if he had a preference and he had a strong opinion on this. He said he'd like to see this notation on the left side so his eyes aren't bouncing back and forth to find information.

Thanks for asking!

TedCC1209 commented 3 years ago

I just went and asked Chris Johnson if he had a preference and he had a strong opinion on this. He said he'd like to see this notation on the left side so his eyes aren't bouncing back and forth to find information.

Thanks for asking!

Sounds good to me. @AntonioGloria sorry to keep changing this on you as we figure out the best solution, but can you have the entire label be placed where you currently have "Top KD Down 2 Holes"? 3 lines of info if top KD is down a hole or two, one line of info if the top KD is not down a hole.

Thanks,

Ted

jagg87 commented 3 years ago

Hi @TedCC1209 and @sarahhightower, Yes, I can make these adjustments. Just one question - how likely is it for a hanging opening to have more than 1 flat crown segment? Or for there to be more than 1 hanging opening with flat crowns on them on the same wall?

TedCC1209 commented 3 years ago

Thanks @AntonioGloria -- It is going to happen that we have more than one segment on the same wall, so I would be sure to have it check to see if the various segments are the same height and build as each other so that it doesn't duplicate the label for every segment. ((EDIT I previously said we need to limit flat crown to 96", but we do not need to since we are just exporting lengths of flat crown, but there will still be scenarios where there will be more than one segment of flat crown on a wall)).

However, there also might be a scenario where there is flat crown to the ceiling in one area on a wall and then another area of flat crown connected to topshelf on the same wall and they might have different height dimensions, but they will 99% of the time be a different height (vertical location) on the wall too so if the label is directly to the left of the flat crown then it should be easy to have multiple flat crown labels in that situation.

jagg87 commented 3 years ago

So @TedCC1209, for example, with flat crown segments of different heights, should it look like this? MockUp_FCLabel_Changes

TedCC1209 commented 3 years ago

The two 3" tall flat crown labels should be combined because they are the same height and in the same horizontal plane. The 13" flat crown label should be higher on the wall (probably even with the centerline of the crown) and because it is to the ceiling likely would also have the top KD one or two holes down. Let me know if that makes sense.

Thanks, Ted

jagg87 commented 3 years ago

Hi @TedCC1209 and @sarahhightower,

The changes to the Flat Crown labels are ready.

fc_01 fc_02 fc_03

Changes are available here: https://github.com/nailsonlandim/SNaP-Dev/tree/issue_%23257-label-flat-crowns

TylerStandage commented 3 years ago

This looks good to me, thanks @AntonioGloria. I believe ready for merge.

TylerStandage commented 3 years ago

@ClassyTeddy I'm moving to ready to merge