search

ClassyKit / Classy

Expressive, flexible, and powerful stylesheets for UIView and friends.
http://classykit.github.io/Classy/
MIT License
740 stars 76 forks source link

Fixed Swift class resolution when app name has spaces #104

Closed Aggouri closed 8 years ago

Aggouri commented 9 years ago

Swift class name resolution does not work when the App Name has spaces in it. The parser fails to find Swift classes and reports an error.

This pull request fixes the issue by replacing all occurrences of " " (space) in the App Name with "_" (underscore), when resolving the Swift class name.

mikeger commented 8 years ago

@Aggouri interesting, thanks for the PR! And sorry for the late reply :)

Do you have a reference link for this, or you researched this on your own? I am wondering if it is only the case with spaces, or would also happen with some other special characters?

Aggouri commented 8 years ago

Hi, sorry I don't have a reference link. My app has a space in the name, so I found out the hard way. I'm afraid I don't remember where I found the info, but I guess it could happen with other characters :-(

mikeger commented 8 years ago

@Aggouri that's fine, thanks