Multiple style class support

ClassyKit / Classy

Expressive, flexible, and powerful stylesheets for UIView and friends.

http://classykit.github.io/Classy/

MIT License

740 stars 77 forks source link

Multiple style class support #34

Closed AlexanderNey closed 10 years ago

AlexanderNey commented 10 years ago

Hey mate,

I added support for multiple style class values (as in CSS) and updated the sorting order of the selectors so that the last one (on cad file) overwrites the previously declared one. I am not sure what my implications my changes in the styleItem: method will have as your previously traversed the style nodes in reverse order.

I did not update the parser to support selectors with multiple classes (like CSS: .style1.style2) but it works fine if you declare just multiple selectors.

Please let me think what you think about that.

Cheers,

Alex

Changelog:

added support for multiple style_class values by assigning a string which can contain whitespace separated values
changed the sorting of the style selectors by precedence so that it matches the order in the cas file (would match more the behaviour of the CSS standard)
changed styling order of items to traverse style nodes from top to bottom order instead of reverse

cloudkite commented 10 years ago

@Ajax64 Nice, thanks for the contribution!

Seems inefficient to have to split the cas_styleClass string everytime we check if selector matches. Since this is something that happens very often need to make sure it's as efficient as possible. What are your thoughts?

Have you come across the need for multiple style classes quite often?

andreyvit commented 10 years ago

Personally, I do need multiple style classes (at least two) quite often, and end up having to concatenate the names and list them all inside the .cas file, which is highly inconvenient. For example, a few minutes ago I've used .incomingMessage and .outgoingMessage classes because I couldn't do .message.incoming and .message.outgoing. It gets ridiculous when there are more states involved (like perhaps .message.incoming.invalid).

cloudkite commented 10 years ago

@Ajax64 @andreyvit happy to reopen if my earlier concerns are addressed and test cases please :)

andreyvit commented 10 years ago

Sure, I'll try to find some time to work on it, unless @Ajax64 beats me to it.

AlexanderNey commented 10 years ago

Hey guys,

I am very sorry to have abandoned this but I had some very busy weeks (deliver time ;) ). I am currently working with my prototype solution and I'll happy to finish that in the next two weeks if that is ok with you.

I am using multiple classes heavily for my prototypes - so I'll happy to see that going in to the project.

@andreyvit did you start already?

andreyvit commented 10 years ago

@AlexanderNey Nope, didn't start, deadline time here as well. :-)