Improve performance with style lookup table

ClassyKit / Classy

Expressive, flexible, and powerful stylesheets for UIView and friends.

http://classykit.github.io/Classy/

MIT License

740 stars 77 forks source link

Improve performance with style lookup table #66

Closed keithnorm closed 10 years ago

keithnorm commented 10 years ago

Hey Jonas, would love to get your input on this implementation. Let me know if this seems reasonable or if you have thoughts on any different approaches. This became necessary for the app I'm working in as the number of style rules got up above 50 or so, the amount of looping done when checking all rules against each view started to have a noticeable impact on performance. Thanks!

cloudkite commented 10 years ago

@keithnorm Looks great! thanks for having a crack at this. Do the tests still pass locally? sorry need to fix up the travis build.

keithnorm commented 10 years ago

Yep the tests pass locally.

cloudkite commented 10 years ago

Thanks for the contribution! :+1: