Add 64Bit support for floats

ClassyKit / Classy

Expressive, flexible, and powerful stylesheets for UIView and friends.

http://classykit.github.io/Classy/

MIT License

740 stars 77 forks source link

Add 64Bit support for floats #88

Closed flippinjoe closed 9 years ago

flippinjoe commented 9 years ago

On 64Bit systems the doubleValue is being truncated when being sent to properties of 'float' type. Example being CALayer.shadowOpacity.

This PR creates a dedicated primitive conversion for Float types to handle this truncation

ryang1428 commented 9 years ago

:+1:

flippinjoe commented 9 years ago

@cloudkite Sorry for the big PR. The float / double fix turned out to break some tests, then I noticed some other tests were failing as well, so I went ahead and cleaned those up. Let me know if you've got any questions

cloudkite commented 9 years ago

@flippinjoe21 No problem, at first glance looks great. Will hopefully review in next couple of days

cloudkite commented 9 years ago

@flippinjoe21 looks great, Thanks!