search

ClaudioMerola / ADxRay

Active Directory's Health Check script that generates a full HTML report of the environment's health, security and status based on Microsoft's Best Practices.
GNU General Public License v3.0
93 stars 37 forks source link

Missing test name in inventory XML #7

Open darvarr opened 2 weeks ago

darvarr commented 2 weeks ago

Hi Claudio, while I was using your script (thanks for that first of all) I noticed that some alarms in the DC Diagnostic Tool were not accurate (they state that the test was missing). In the Inv_$DC.xml file the names of the tests were missing in some places, the result is that the .ps1 script won't find them and report they are missing. Do you have any idea on how can this happen? I attached two screenshots of the .xml file and the .html report.

P.S. in the screenshots you will see the .xml in Italian. I edited your .ps1 script to recognize also Italian when looking for test results in the .xml files.

screen screen_2

ClaudioMerola commented 5 days ago

Hello,

I don't get what the issue is. I believe that if the result is missing in the DomainController .xml file it will be missing in the html report.

Are you sure you translated the dc diag tests in every part of the script?

I believe these texts are used in many places, like the: "$DCD.DCDiag | Select-String -Pattern ($DC +' passed test Advertising'"

darvarr commented 5 days ago

Hi Claudio, thanks for replying. By now I run your script without any edit to test this behavior (at this stage I don't care about languages).

In the attached screenshot you may see the first group of passed test (rows 6339 and 6343) where you read (translated in English for non Italian readers) "has passed the test KccEvent".

In the second group of passed test (rows 6380 and 6384) you can see that there's only the sentence "has passed the test" without any name of such test (like KccEvent in the first group). And indeed I can see that some tests are missing in the HTML file (of course, if they are not present in the XML).

So my question is: is the sentence "has passed the test" without any further info about the passed test (i.e. the name of the test) correct? Or are there some problems in the script and that's why the name of the tests don't appear in the XML?

This is to understand why some tests are missing even if such problems are not present on the DC (for example the Connectivity).

screen2