Upgrade deps and add linting & formatting

ClaudiuCeia / detect-translation

🗿 Attempts to detect when a website was automatically translated (either on the client, or via a proxy)

MIT License

6 stars 2 forks source link

Upgrade deps and add linting & formatting #3

Closed DuncanMacWeb closed 4 years ago

DuncanMacWeb commented 4 years ago

As preparation to make a PR for #2, I’ve upgraded TypeScript and added eslint, prettier and jest-environment-jsdom-global to allow tests to modify window.location.

Hope this looks good to you but happy to make changes!

ClaudiuCeia commented 4 years ago

Looks good! I personally prefer async/await over using Promises directly - but it's just a pet peeve :) Keep 'em coming! Adding you as a maintainer now

DuncanMacWeb commented 4 years ago

Thanks! :) I also prefer async/await but couldn’t work out how to use it in that context—feel free to fix!