Detect langs based on substrings

ClaudiuCeia / detect-translation

🗿 Attempts to detect when a website was automatically translated (either on the client, or via a proxy)

MIT License

6 stars 2 forks source link

Detect langs based on substrings #5

Closed DuncanMacWeb closed 4 years ago

DuncanMacWeb commented 4 years ago

Hi again! Hopefully this makes sense but there’s quite a lot here, let me know if you have questions about anything. The substrings themselves are generated from the translation source file at build time. I’ve refactored the API a bit too, hopefully not too much. There are also notes, including TODO: comments in places. Happy to refactor/remove anything!

This closes #2.

lgtm-com[bot] commented 4 years ago

This pull request introduces 3 alerts when merging 3e98e5397a54acdee7a94dc0b9108de812c47bc7 into ab4e45a24ed8ee81b01786801fd88316afa745f0 - view on LGTM.com

new alerts:

1 for Implicit operand conversion
1 for Useless conditional
1 for Incomplete string escaping or encoding

lgtm-com[bot] commented 4 years ago

This pull request introduces 3 alerts when merging 633b61f1f1ae3781b425de740586185f0759b3ad into ab4e45a24ed8ee81b01786801fd88316afa745f0 - view on LGTM.com

new alerts:

1 for Implicit operand conversion
1 for Double escaping or unescaping
1 for Incomplete string escaping or encoding

ClaudiuCeia commented 4 years ago

Thanks! I'll take a look tonight, I'm a bit caught with work now :)

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging fe75bf13c0e8bcd08871a842a81df3c246efd06d into ab4e45a24ed8ee81b01786801fd88316afa745f0 - view on LGTM.com

new alerts:

1 for Implicit operand conversion
1 for Incomplete string escaping or encoding

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging 9535dffe6908004c479c0c171d74ce6023ca2efd into ab4e45a24ed8ee81b01786801fd88316afa745f0 - view on LGTM.com

new alerts:

1 for Implicit operand conversion
1 for Incomplete string escaping or encoding

DuncanMacWeb commented 4 years ago

I think it would make sense to “squash and merge” this PR once we’re happy with it btw (in the dropdown on the “Merge pull request” button).

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging 831a29aba71dced2e557cd197071343e52c55f71 into ab4e45a24ed8ee81b01786801fd88316afa745f0 - view on LGTM.com

new alerts:

1 for Implicit operand conversion
1 for Incomplete string escaping or encoding

DuncanMacWeb commented 4 years ago

@ClaudiuCeia I’m happy with this branch now, so I’m minded to merge, shout if you have any changes in mind!

DuncanMacWeb commented 4 years ago

Hope all is good with you @ClaudiuCeia. I’ll go ahead and merge tomorrow if there are no changes to make 👍