Road to 2.0 - New Challenger Potion needs to consider Sacred Bark (Thanks to Discord's gkjzhgffjh#4772 for giving the "Super Elite" idea, and JohnnyBazooka89#8560 for giving me his code that does a similar thing)

[Clauvin]

Ok, this potion does not need to be affected by Sacred Bark 👍

Issue done, without a single line of code.

[Clauvin]

Nope. Let's make it affect Challenger Coin, just make the first potion used give an extra one if Sacred Bark is available.

[Clauvin]

Ok, Gk gave a better idea.

Instead of giving an extra potion, make the potion transform the room into an Burning Elite room and make the fight give one extra Relic.

[Clauvin]

Ok, JohnnyBazooka89#8560 gave his code, and it helps, but I have some hiccups in terms of how things work for his code and mine:

• His code works by adding a field to rooms and calling functions to make the Emerald Elite rooms work. My code works changing the rooms and calling code after the load to redo the necessary changes.

• His code has a relic to ask when the need of a Emerald Elite room is needed, I don't, all that I can count is save and load.

• My code needs to give an extra relic.

So, I will have to reread my code to see where my patches will have to diverge from his.

[Clauvin]

Ok, good news. It seems that I had already counted with EmeraldElite because of Act 3 and the need of the Emerald Key, so making the relic spawn Emerald Elites won't be much of an issue.

My problem is with adding an extra relic, but let's do the first editing and testing first.

[Clauvin]

Ok, if I got this right, the game does not expect that more than one Burning Elite room would show up.

So, I will have to use code that reference stuff from New Challenger Potion to apply the effects AND the extra relic. Will still need to use Bazooka's code.

[Clauvin]

Also I'm giving the wrong key -_-

[Clauvin]

Ok, I still have to commit the new code, but it's not working: for some reason, the function to add the buffs is not adding the buffs? Have to check how it is working.

[Clauvin]

I referenced the issues on the wrong place. Again. sigh

Very well. I have two options at this point.

1 - I manage to piggyback on a function of AbstractRoom to apply the effects when they should be applied, ignoring the whole Emerald Room dillema, and leave the burning not working on all modes; 2 - Patching.

Will try 1, if that does not work, 2.

[Clauvin]

Also, have to make sure that everything works even without an Emerald Key being given thanks to a specific chosen mode.

[Clauvin]

WITHOUT A PATCH O/