ClavelLab / maldipickr

Dereplicate And Cherry-pick Mass Spectrometry Spectra
https://clavellab.github.io/maldipickr/
GNU General Public License v3.0
2 stars 0 forks source link

set min R version (fixes #31) #33

Closed cpauvert closed 10 months ago

codecov[bot] commented 10 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

cpauvert commented 10 months ago

Setting up the package on R-3.2.5 using rig threw and error as {maldipickr} dependencies could not be installed:

ERROR: dependencies ‘dplyr’, ‘magrittr’, ‘MALDIquant’, ‘readBrukerFlexData’, ‘rlang’, ‘tibble’, ‘tidyr’, ‘tidyselect’ are not available for package ‘maldipickr’  in R 3.2.5

Looking up what are the R requirements for these dependencies, borrowing code from r-hub blog

db <- tools::CRAN_package_db()
deps <- c("dplyr", "magrittr", "MALDIquant", "readBrukerFlexData", "rlang", "tibble", "tidyr", "tidyselect")
db |> dplyr::filter(Package %in% deps) |> dplyr::select(Package, Depends)

highlights that MALDIquant prevented the install on the old release

             Package               Depends
1              dplyr          R (>= 3.5.0)
2           magrittr          R (>= 3.4.0)
3         MALDIquant R (>= 4.0.0), methods
4 readBrukerFlexData          R (>= 3.3.0)
5              rlang          R (>= 3.5.0)
6             tibble          R (>= 3.4.0)
7              tidyr          R (>= 3.4.0)
8         tidyselect            R (>= 3.4)
cpauvert commented 10 months ago

works with R 4.0.5, so should probably bump min R version to 4. No, min R version relates to this package, but I'll had a note in the NEWS.