ClayHanson / BlocklandRebuilt-IssueBoard

Beta testing for Blockland Rebuilt.
6 stars 0 forks source link

Bricks that change color or fx cause nearby bricks to blink #248

Closed Zinlock closed 6 months ago

Zinlock commented 1 year ago

Bug Description

When a brick changes colors or fx, it blinks along with any other brick it covers

Screenshots

https://github.com/ClayHanson/Blockland-Rebuilt-BetaTesters/assets/33813303/0604e8fd-b92a-4f78-bbc8-786a91755fcf

Metadata:

Kenkoman commented 1 year ago

I'm also noticing bricks blinking after theyve been planted and the color fade-in finishes. This causes entire loaded-in saves to blink and lag the whole game

ClayHanson commented 1 year ago

when a brick is planted, its animation causes it to be in the fxBrickBatcher system, which is much slower. Then, depending on its attributes (colorfx, shapefx, transparency, etc) it will be considered into the OctTree for static rendering, which is way faster. If it makes it into that tree, it invalidates its OctNode's mesh so it updates with the new brick. The blinking is happening because there is some time between the node's mesh being updated and the renderbuffers being updated.

In short, the lag is unavoidable (unless you don't want a plant animation anymore).

Kenkoman commented 6 months ago

It appears this was fixed at some point, closing