Use built in function to get terminal size

CleanCut / green

Green is a clean, colorful, fast python test runner.

MIT License

793 stars 75 forks source link

Use built in function to get terminal size #139

Closed MinchinWeb closed 7 years ago

MinchinWeb commented 7 years ago

This seems to work, except for Pypy3.

the function needed (shutil.get_terminal_size) has been added to Pypy3, but I guess not the version running on Travis (see this issue)
on Travis, it claims it can't import the library, even though it's listed as installed ??? (see this Travis build)

@CleanCut: thoughts on how you think best to fix this?

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 1973aaac1481def6f8963f14417af1b532feea4b on get-terminal-size into 7688b475b4fffff1088a0c84b45ef8696285e3cd on master.

CleanCut commented 7 years ago

This one took a while to track down.

It all comes down to the fact that modern versions of pip no longer support Python 3.2. As in, pip doesn't actually function correctly on Python 3.2 any more.

That particular test installs the latest virtualenv and then runs the test inside the virtualenv. The virtualenv installs and uses the latest version of pip. pypy3 is stuck emulating Python 3.2.5 (I'm honestly bewildered that they haven't bumped up emulation to a later version by now, they've been on that version for many years).

So, pypy3 is too old to support. I never supported Python 3.2 anyway. pypy3 just happened to work well, so I supported it. Until now.

Time to drop pypy3 support until they can target 3.4+.

My advice to you would be, add a commit that removes all pypy3 stuff.

CleanCut commented 7 years ago

For reference: https://github.com/pypa/virtualenv/issues/879

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 11f8ae73e1086c2556e947d746dd53e3606900a7 on get-terminal-size into 92b88d47f5ce9c1213add38247a7cf3433001917 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling de6f146846eb825d10d36177e21b3a23e478365a on get-terminal-size into 92b88d47f5ce9c1213add38247a7cf3433001917 on master.

MinchinWeb commented 7 years ago

For now, I've moved PyPy3 to an 'allowed failure'. It seems that PyPy3 is moving forward -- the v5.5.0 builds are supposed to target Python 3.3, but I couldn't get it running on Travis-CI. As well, I guess Mozilla has kicked in funding to update the target to Python 3.5. So I leave the PyPy3 test there in the hopes that one day it will just starting working again by itself.

I've also removed mention of supporting PyPy3 from the Readme's.

MinchinWeb commented 7 years ago

P.S. that was impressive to track down the bug!

CleanCut commented 7 years ago

Thanks! Some days I feel like I have a knack for bug-finding. Other days, it's just a knack for bug-writing...