Closed althonos closed 7 years ago
Also...I wonder if we should change our config-file resolution behavior from merge-all to "first config wins..." Something to ponder.
I've been pondering it. I like the current merging-of-configs behavior, I think.
By the way, if you feel like you need some help with my review suggestions, let me know and (I think) I can make a PR to your PR adding some of the stuff. If that helps.
Merging is okay, this allows changing some things locally while having a global configuration that is used everywhere, both of which can be updated independantly.
I do not agree with setup.cfg
being the least in priority however, since it is a local configuration file (at the root of a Python project): it should have precedence over the global settings, as the .green
file does.
EDIT: Oh, I see what you mean, not absolute first but just come before .green
.
Yes, I meant switch it with .green
. Sorry, I could have explained that more clearly.
Included in just-released version 2.9.0.
While I am at it, I added support for green configuration inside
setup.cfg
, since there seem to be an almost official agreement about using this file for Python dev tools configuration.setup.cfg
is the only file where the[green]
section is expected.