search

CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
786 stars 74 forks source link

Add subtest support (https://github.com/CleanCut/green/issues/111) #167

Closed VladV closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 99.604% when pulling a676713875e28d790f0068105d90788c586dee4e on VladV:master into 81b8b8633d5b5bef8b0b99794a3be49f04135cba on CleanCut:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 99.604% when pulling a676713875e28d790f0068105d90788c586dee4e on VladV:master into 81b8b8633d5b5bef8b0b99794a3be49f04135cba on CleanCut:master.

CleanCut commented 6 years ago

Thank you for putting in the time and effort to get this going! It is efforts like yours that keep projects like this alive.

I extended your patch and made it so that if all subtests pass, you get a single test succeeding. Otherwise you get a test failure/error for each subtest that failed/errored. I would rather have a different behavior, but due to unittest's odd choice of implementation, that would be really, really hard to accomplish. I also fixed it so that in both cases the count of tests adds up correctly. And I wrote tests for the new feature. And fixed the cursor-rewinding-a-different-length-than-it-should bug. And some other minor stuff.

If you're interested, you the commit is a302858bc4

CleanCut commented 6 years ago

Resolved in 2.11.0 (just released).