search

CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
795 stars 76 forks source link

Added Windows CMD support by importing colorama into output.py #19

Closed dougthor42 closed 10 years ago

dougthor42 commented 10 years ago

Colorama plays nicely with Termcolor. It was a simple change to get Windows support for green.

https://pypi.python.org/pypi/colorama

When accepted, closes issue #18

CleanCut commented 10 years ago

I'm all for this feature, but it needs to be implemented cleanly. There's two choices:

a) Keep using termstyle and conditionally add colorama as a dependency (in setup.py) only on windows (I don't want to add colorama as a dependency and make OS X and Linux users install it if it's not actually being used on those platforms). Then only import and init colorama on windows.

b) Completely switch from termstyle to colorama.

I'd be fine with you implementing one of those strategies and updating your pull request, or you can wait a few days and I'll give it a shot.

dougthor42 commented 10 years ago

I'll do some work and see which one makes more sense. Might not happen this weekend though, what with 4th of July and all.

As for testing, I've verified that the 2 line change I made works but I didn't do it via unittest - just made the change directly to python-2.7.6/Lib/site-packages/green and ran it once. Definitely more testing will be needed before merging.

CleanCut commented 10 years ago

Ya, 4th of July will probably put me off until next week too.

If you pull from master, there shouldn't be anything failing your build any more. I just moved my in-progress development into branches and cleaned up the master branch. Until this week, I was developing by myself linearly, so I didn't bother setting up branch-based-development.

Whenever you push, Travis ought to run the four linux builds and you can click on it if it fails and see what's going on.

CleanCut commented 10 years ago

Well, nothing I did failing your build, at least. :-)

CleanCut commented 10 years ago

I got set up on a WinXP VM and implemented option "a" today. I'm preparing a release.

CleanCut commented 10 years ago

Implemented in 1.0.2 (just released).