search

CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
785 stars 75 forks source link

Replace termstyle with colorama #199

Closed Ogaday closed 5 years ago

Ogaday commented 5 years ago

PR to resolve #186.

Ogaday commented 5 years ago

The replacement is a little complicated by the fact that colorama and termstyle handle things differently; it seems colorama is a little more clever, and will handle all the ANSI codes as they're printed, not before, unlike termstyle. See the commit message for 9aefd32. However, this gives us less control. So far, I'm trying to replicate the old logic with the new lib. As I said in the commit message, I'm not sure if the call to restoreColor is actually necessary or not.

Still to come are removing references to termstyle from the docstrings & config.

CleanCut commented 5 years ago

✅ I'm going to merge this and finish it up. Thanks for getting this started!

Ogaday commented 5 years ago

Yay, thanks! Wasn't sure what was needed to finish this up and I was a bit confused by the different assumptions they made. Good to see this merged in.

CleanCut commented 5 years ago

Included in 2.13.1 (just released).

CleanCut commented 5 years ago

@Ogaday No problem! Thanks for getting this going--that really helps me. Time is my scarcest resource.