Prevent green from hanging on internal failure during error reporting.

charles-l commented 4 years ago

green currently hangs when trying to run with a doctests in the load_tests call:

(save the following to a file named test_doctest.py):

import unittest                                                                                                                                                                                                                                                                                                                
import doctest                                                                                                                                                                                                                                                                                                                 

def f():                                                                                                                                                                                                                                                                                                                       
    '''                                                                                                                                                                                                                                                                                                                        
    >>> f()                                                                                                                                                                                                                                                                                                                    
    2                                                                                                                                                                                                                                                                                                                          
    '''                                                                                                                                                                                                                                                                                                                        
    return 2                                                                                                                                                                                                                                                                                                                   

def load_tests(loader, tests, ignore):                                                                                                                                                                                                                                                                                         
    return doctest.DocTestSuite('test_doctest')

This patch catches the exception that's thrown in the worker and reports it back. Before, the workers would bail and become defunct processes, while the scheduler process would hang because it was waiting for a result from the queue (which never showed up)

This doesn't fix the underlying issue with doctest (unfortunately), but it at least prints the error and prevents green from hanging.

charles-l commented 4 years ago

Oh, interesting -- it looks like the bug is actually in the GreenTestLoader class. When I run poolRunner('test_doctest', ...) (so it imports it directly without wrapping in the GreenTestLoader), the tests run as expected. I'll try and dig into that issue and see if I can't fix it...