CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
785 stars 75 forks source link

Raising an exception in setUpClass results in the test case being skipped #244

Closed grant-zietsman closed 3 years ago

grant-zietsman commented 3 years ago

I would expect the exception to ripple up but it seems like it is swallowed and the tests in the failing test case are ignored. The result is a faulty positive.

CleanCut commented 3 years ago

(sigh) Ah, yes upstream setUpClass behavior is a travesty which I have long been dealing with.

I'd welcome help finding and fixing the problem. It will most likely be in one of these functions. If you are on Python 3.7 or earlier, you'll want to focus on _handleClassSetUpPre38, otherwise look at _handleClassSetUpPost38.

Otherwise, post your output of green --version and your OS version and I'll see if I can get to it sometime.

grant-zietsman commented 3 years ago

I followed up and realised this was a calling code mistake. Apologies.

CleanCut commented 3 years ago

No worries! It's nice that there's not a larger issue to be tracked down this time. 😄