search

CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
785 stars 75 forks source link

Feature Request: unittest timeout #248

Open sodul opened 3 years ago

sodul commented 3 years ago

We thrive to make our unittests very fast through proper targeting and mocking. Unfortunately once in a while a new "unittest" will take over 1m. We would like to capture that as part of our CI pipelines. We can probably parse the test results XML but I thought this could be a nice feature to have in green.

The timeout would not be for test suites but for individual tests.

CleanCut commented 3 years ago

I'm not personally interested in this feature. If you (or anyone else) would like to attempt it, the place to start would be in poolRunner. I'd be happy to review the pull request.

sodul commented 1 year ago

@CleanCut I'm considering spending some time to move this forward but since the code handling threads has conditional logic for backward compatibility with older versions of Python (at least it did when I looked into it in 2021), I would like to first refactor the existing code to simplify the logic and only support newer versions. Your test matrix currently includes 3.8, 3.9 and 3.10.

Would you be comfortable with me contributing a few PRs that only ensure support for these versions (and newer of course, like 3.11) ?

CleanCut commented 1 year ago

Green currently supports Python 3.5+. I would prefer to not intentionally break support for older versions unless we find a good reason for it.

What if you gave it a try as-is, and then removed the support if it actually caused problems?

sodul commented 1 year ago

I'm only considering removing code for python 2, if that's ok with you.

CleanCut commented 1 year ago

I'm fine with removing the Python 2 code, now. We're ~3 years past it's official EOL.