search

CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
795 stars 76 forks source link

Address 'addDuration' warnings in python 3.12. #275

Closed sodul closed 11 months ago

sodul commented 11 months ago

This is new to python 3.12 and throws warning on every single test. This adds the new method and related property. Longer term we should probably inherit from the official TestResult class as to ensure better forward compatibility.

This depends on #274.

coveralls commented 11 months ago

Coverage Status

coverage: 99.918% (-0.08%) from 100.0% when pulling 87c28a7ec6b3f2c50fecfab7558ac9347b185fee on clumio-oss:py3.12-warnings into ff8d950c059ffe1ad954919dea7ea2941b92935e on CleanCut:main.

sodul commented 11 months ago

There seem to be a race condition on a temp file in Windows with Python 3.6. I do not know if this is a flaky issue. I would recommend to follow the rest of the python community and drop support for 3.6 and 3.7 after doing a final release from main as the last version to support them, with 3.8 being the new oldest supported version.

CleanCut commented 11 months ago

Can you merge my main into this branch? That should resolve the CI errors.