Fix test_time being always 0.0

CleanCut / green

Green is a clean, colorful, fast python test runner.

MIT License

785 stars 75 forks source link

Fix test_time being always 0.0 #292

Closed eltoder closed 2 months ago

eltoder commented 2 months ago

The bug was introduced in commit 651ab467e371b42e6205b9c3d223f2e1f50e4b0a when setting start_time = 0.0 was added to ProtoTestResult.reinitialize().

eltoder commented 2 months ago

It's probably a good idea to do a thorough testing of everything given the amount of recent changes.

coveralls commented 2 months ago

coverage: 0.0%. remained the same when pulling 2606d63df3d1560a70c50dc854322945ccf88fac on eltoder:feature/fix-test-times into 9e9e5cfe8b0a213899df78d3e06db4f592bbc84b on CleanCut:main.

sodul commented 2 months ago

Thanks for the PR and sorry for introducing this bug. I'm not sure why I did not notice it.

eltoder commented 2 months ago

Btw, looks like the coverage number in the CI is wrong ^^

sodul commented 2 months ago

For the lack of coverage we are tracking this in #289 but I have not had time to look into it since it seems to be limited to green's GH action. Local coverage numbers are fine.