CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
792 stars 75 forks source link

Ensure file handles are closed using with statement #33

Closed svisser closed 10 years ago

svisser commented 10 years ago

This change ensures the file handles in setup.py are closed using the with statement.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 25b9330b6341a9198bbc9733b65563469352cd6e on svisser:patch-1 into 3c0a3932a240dd2fc1a27179ec231ab10af3c2ff on CleanCut:master.

CleanCut commented 10 years ago

Awesome, thanks! Did this fix a specific problem you were having?

CleanCut commented 10 years ago

I released 1.4.4 with your contribution.

svisser commented 10 years ago

Thanks! It didn't fix a particular problem, it's more a matter of closing file handles when possible.

CleanCut commented 10 years ago

Great, thanks for catching that.