search

CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
792 stars 75 forks source link

loader: Don't add tests which have __test__ set to False #40

Closed smspillaz closed 9 years ago

smspillaz commented 9 years ago

This attribute is set by nose.tools for functions that shouldn't be considered tests (usually because they're a base for a generated test function).

This change enables nose_parameterized with green.

Fixes #39

smspillaz commented 9 years ago

I note that the tests are failing on travis-ci. I'm not sure why that is - it appears to be for an unrelated reason.

CleanCut commented 9 years ago

@smspillaz I think you're right. I think the version of pip changed on Travis CI, which is causing the failures. I'll try to get those fixed today, and then I'm planning on merging your pull request -- it looks good!

CleanCut commented 9 years ago

Yep, I adjusted requirements.txt and that fixed the pip problem. I'm going to try merging this. Do you have any examples of how this enables using nose's parameterized thing? I haven't actually used that feature myself, though I think I understand the concept. It may make sense to add an example to the ReadMe and/or Changelog.

CleanCut commented 9 years ago

@smspillaz How would you like me to refer to you in the changelog? I like to attribute feature contributions in the changelog, and I have found that different people have wildly different preferences. (Everything from "don't mention me!" to "Use my full name!" and several things in-between.

smspillaz commented 9 years ago

@CleanCut Oops, I just saw this now.

ChangeLogs: I don't mind - whatever you see fit. nose_parameterized: You can find some examples here

CleanCut commented 9 years ago

@smspillaz I'll put down your first and last name, then.

CleanCut commented 9 years ago

Included in green 1.8.0, released today.