search

CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
792 stars 75 forks source link

Change blue to cyan for skipped tests #59

Closed dougthor42 closed 9 years ago

dougthor42 commented 9 years ago

The blue color tends to not show up very well under windows CMD:

image image

If changed to cyan: image image

Diff for output.py

--78: return termstyle.blue(text)
++78: return termstyle.cyan(text)
CleanCut commented 9 years ago

Sorry for the slow response, I've been swamped in my day job lately.

Question: Is that the default "blue" color on Windows? (if so, what a stupid default color to choose for blue against black, microsoft)

In my experience with Linux and OS X, the default color scheme has blue a readable color, and if people customize their color scheme, then they ought to make sure blue ends up readable.

But if the default is unreadable, then I will probably change it to cyan just for Windows. (Seems like all the special cases are "just for Windows").

dougthor42 commented 9 years ago

Haha yeah, it's the default color for Windows CMD :-(

Thanks,

CleanCut commented 9 years ago

I fixed it in the upcoming 1.9.3 release. Would you like me to mention you in the changelog? If so, would you prefer I use your user name or real name?

dougthor42 commented 9 years ago

No need to mention me. :-) Though if you do, I guess I'd prefer username.

Thanks!