CleanShare / Issues

Raise any bugs or feature requests here.
4 stars 0 forks source link

Support for Japanese localization #9

Closed katagaki closed 6 months ago

katagaki commented 6 months ago

Is your feature request related to a problem? Please describe.

I have the share sheet set up with Copy and Copy (Without Tracking) on top of each other. Currently, the app is in English, which makes that look a little off when used on a device with Japanese localization set up.

Describe the solution you'd like

I can provide Japanese localizations for the app.

Describe alternatives you've considered

N/A

Additional context

N/A

ptrkstr commented 6 months ago

Thank you for raising this @katagaki, that sounds like an excellent idea 😍 I will respond when I have a language file ready for translation.

ptrkstr commented 6 months ago

@katagaki I've attached the japanese translation strings catalog. You will need a tool like Xcode 15 to be able to edit them. When you open it, the sections needed translation would be:

Once you're finished you could zip and reupload here, thank you so much 🙏

ja.xcloc.zip

katagaki commented 6 months ago

@ptrkstr Thank you for sharing the localization files! Attached is the completed localization, which you can use in Clean Share. Below the attached file are the localization notes, which you can refer to for my comments while localizing the files.

ja-localized.xcloc.zip

Localization Notes

ptrkstr commented 6 months ago

Thank you so much for the translations 🙏 I will integrate them now. I would like to give you credit in the help screen of the app, could I link to your github profile? Something such as: "Japanese translation provided by katagaki". If that sounds good, could you provide a translation for that as well? 😅

katagaki commented 6 months ago

@ptrkstr

Thank you, that would be great! Please see the below text:

日本語の翻訳はkatagakiさんより提供しました。

ptrkstr commented 6 months ago

Thank you @katagaki, everything has been submitted to Apple and will be in the next 1.0.12 release. If there are any issue with the translation feel free to reopen the ticket 🙏