search

CleanroomMC / BetterQuesting

Forked BetterQuesting with many new features and optimizations
MIT License
9 stars 19 forks source link

Random quest ID #110

Closed KatatsumuriPan closed 1 month ago

KatatsumuriPan commented 3 months ago

Now newly created quest ID will be random. This prevents merge conflicts when multiple people try to add or remove quests simultaneously.

Changing the type of quest ID from int to UUID is pending for compatibility.

I won't apply this change to quest-line ID and other IDs until https://github.com/CleanroomMC/BetterQuesting/pull/103 is merged.

KatatsumuriPan commented 3 months ago

problems:

  • similar logic should also apply to questlines

I won't apply this change to quest-line ID and other IDs until https://github.com/CleanroomMC/BetterQuesting/pull/103 is merged.

question: what is the logic that leads to continuing to use an int instead of switching to using a UUID, as was done in https://github.com/GTNewHorizons/BetterQuesting/pull/89?

I think the only advantage of UUID is their randomness. Considering the cost and trouble, I don't think there is any benefit to changing to UUID.

Rongmario commented 1 month ago

Closing in favour of #113. Thank you for all the work!