search

CleanroomMC / BetterQuesting

Forked BetterQuesting with many new features and optimizations
MIT License
10 stars 21 forks source link

Convert EDIT_MODE into a Gamerule #77

Closed WaitingIdly closed 3 months ago

WaitingIdly commented 1 year ago

Convert edit mode into a gamerule (defaults to false). This does not change the command (/bq_admin edit works the exact same). This prevents an issue where edit mode would unexpectedly be considered enabled. Additionally, since it is no longer shipped in the DefaultQuests.json file, this also means pack makers no longer have to remember to disable edit mode when saving quests.

Caedis commented 1 year ago

Everything looks good with a quick glance. Have you tested it in singleplayer and in multiplayer/server?

WaitingIdly commented 3 months ago

this simply isnt a viable solution to the problem, as gamerules are server-side and this must be possible to check client-side. also nothing has happened to it for a year and a half.