Incompatibility between CubicChunks/Fugue/CensoredASM and CubicChunks/Valkyrie on Cleanroom Loader

Toku500 commented 1 month ago

Your CleanroomMC Discord Username

Tokusuiku

Cleanroom Version

Cleanroom-MMC-instance-0.2.3-alpha

Java Version

Java 22

Graphics Card Vendor

NVidia

Bug Report

Incompatibility between CubicChunks/Fugue/CensoredASM and CubicChunks/Valkyrie on Cleanroom Loader when repeating those steps :

CensoredASM Crash at startup when CubicChunks and Fugue are enabled inside a Cleanroom Loader instance: https://mclo.gs/e8Y8SJ4

Valkyrie Crash at startup when CubicChunks, Redcore and Valkyrie are enabled inside a Cleanroom Loader instance : https://mclo.gs/MSECQh0

Tested all mods together with Fugue 0.15.10 enabled/disabled and scalar-1.12.2-2.11.1 Enabled/Disabled

Mod List

CubicChunks + CensoredASM+ Fugue ( Enabling or Disabling scalar-1.12.2-2.11.1 do not affect the outcome )

Or

CubicChunks + RedCore + Valkyrie ( Enabling or Disabling scalar-1.12.2-2.11.1 do not affect the outcome )

Fugue 0.15.10 Scalar 2.11.1

MMC Instance Notes

Works perfectly fine on Forge but crashing on startup when using Cleanroom Loader instead.

Final Checklist

[X] I have searched the issues and haven't found a similar issue.
[X] I have read the known incompatibilities and this is not related to one of those.
[X] I have installed Fugue and it does not fix this issue.
[X] I am using experimental branch and have installed Scalar and it does not fix this issue.
[X] I am running a test build from Cleanroom Github Actions. (Or, if I've compiled it myself I plan to fix the issue)

Toku500 commented 1 month ago

( Same issue with Fugue 0.16.3 )

michaelsebero commented 1 month ago

crash-2024-10-07_17.56.00-client.txt

ZZZank commented 1 month ago

The first crash log revealed a duplicate class definition problem from CubicChunk, and does not seem to be related to CensoredASM by any means, please send latest.log

Caused by: java.lang.LinkageError: loader net.minecraft.launchwrapper.LaunchClassLoader @238d68ff attempted duplicate class definition for io.github.opencubicchunks.cubicchunks.core.CubicChunksConfig. (io.github.opencubicchunks.cubicchunks.core.CubicChunksConfig is in unnamed module of loader net.minecraft.launchwrapper.LaunchClassLoader @238d68ff, parent loader 'app')

The second crash is due to Valkyrie, whose mixin injection failed, I think you should be able to reproduce it without CubicChunk

Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Constant modifier method modifyWindowTitle(Ljava/lang/String;)Ljava/lang/String; in mixins.valkyrie.json:MinecraftMixin from mod unknown-owner failed injection check, (0/1) succeeded. Scanned 0 target(s). Using refmap mixins.valkyrie.refmap.json

Toku500 commented 1 month ago

The first crash log revealed a duplicate class definition problem from CubicChunk, and does not seem to be related to CensoredASM by any means, please send latest.log

Caused by: java.lang.LinkageError: loader net.minecraft.launchwrapper.LaunchClassLoader @238d68ff attempted duplicate class definition for io.github.opencubicchunks.cubicchunks.core.CubicChunksConfig. (io.github.opencubicchunks.cubicchunks.core.CubicChunksConfig is in unnamed module of loader net.minecraft.launchwrapper.LaunchClassLoader @238d68ff, parent loader 'app')

The second crash is due to Valkyrie, whose mixin injection failed, I think you should be able to reproduce it without CubicChunk

Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Constant modifier method modifyWindowTitle(Ljava/lang/String;)Ljava/lang/String; in mixins.valkyrie.json:MinecraftMixin from mod unknown-owner failed injection check, (0/1) succeeded. Scanned 0 target(s). Using refmap mixins.valkyrie.refmap.json

https://mclo.gs/X3YYYXG latest.log for the first one

CleanroomMC / Cleanroom