search

CleanroomMC / GroovyScript

A scripting mod for Minecraft without the issues of other scripting mods.
GNU Lesser General Public License v3.0
40 stars 28 forks source link

[Mod Compat] Latest version of AE2-UEL produces a NPE for inscriber recipes #172

Closed glektarssza closed 4 months ago

glektarssza commented 5 months ago

The latest version of AE2-UEL/Applied-Energistics-2 is incompatible due to changes in the API.

The change occurred in PR#430. The withTopOptional and withBottomOptional methods in src/api/java/appeng/api/features/IInscriberRecipeBuilder.java now accept a Collection<ItemStack> instead of a flat ItemStack.

Not sure if there's any desire to fix this issue (since AE2-UEL is, as the name implies, an unofficial extended life fork) but if there is I'd be happy to try my hand at making the fix myself.

WaitingIdly commented 4 months ago

resolved in https://github.com/AE2-UEL/Applied-Energistics-2/pull/464

glektarssza commented 4 months ago

I'll check tonight and confirm.

glektarssza commented 4 months ago

Looks good using the built JAR from that PR merge. Closing this ticket.