search

CleanroomMC / InventoryBogoSorter

A rewrite of the popular Inventory Tweaks mod
GNU Lesser General Public License v3.0
11 stars 9 forks source link

Fix Inventory Bogo Sorter Sorting Inaccessible Slots #76

Closed IntegerLimit closed 3 weeks ago

IntegerLimit commented 1 month ago

This PR fixes Inventory Bogo Sorter Sorting Inaccessible Slots, fixing potential issues with accessing inaccessible items or changing mods' logics.

However, this PR was mainly made to fix a dupe glitch with Thermal Expansion Satchels. The Dupe Glitch can be replicated as following:

  1. Have more than one thermal stachel in your hotbar (in locations that they wouldn't end up being after a sort, such as at the end of an empty hotbar)
  2. Open one of the satchels, and place item(s) inside
  3. Still in the Satchel GUI, sort the player hotbar. Since the locked slot of the currently held satchel has changed, the satchel GUI suddenly closes. As a result of this direct closure, Thermal panics, and now both satchels in your hotbar have the inputted item(s)
IntegerLimit commented 1 month ago

This PR currently has issues with sorting Actually Additions' Storage Crates, which shows all empty slots as 'inaccessible'.

brachy84 commented 1 month ago

I love Actually Additions

IntegerLimit commented 4 weeks ago

Fixed.