search

CleanroomMC / MixinBooter

Allows any mixins that work on mods to work effortlessly. With a single class and an annotation. On 1.12.2.
GNU Lesser General Public License v2.1
50 stars 17 forks source link

8.0+ Incompatibility with DupeFix Project, causes issues with Thermal Expansion and HEI #38

Closed jchung01 closed 1 year ago

jchung01 commented 1 year ago

Wasn't sure if I should post this under #34 because the crash reason is different, so just made a new issue.

As title says, MixinBooter 8 seems to be incompatible with DupeFix Project. The side effect that arises from this incompatibility is a server-side crash (caught by CensoredASM) when trying to open the GUI of any Thermal Expansion (TE) machine, leaving Thermal machines unopenable. Looking through the log, looks like HEI also fails at registering TE stuff as another side effect.

DupeFix has some mixins for Thermal Expansion, but they don't seem to be directly related to the crash. Tested with MixinBooter 8.2/8.3. MixinBooter 7.1 works fine. Here's the mod list: modlist

Crash report latest.log (Line 304 for HEI exception, 3741 for TE)

jchung01 commented 1 year ago

Just checked Vapaman's issue, trying to pickup an item also triggers a crash. It looks like the root cause that is shared between issues then is a java.lang.ClassNotFoundException for cofh/core/gui/container/ContainerCore, shown in debug.log. crash report when trying to pickup an item (results in subsequent crashes on world load as the player keeps trying to pick up the item)

Now, DupeFix does reference ContainerCore in ContainerSatchelFilterMixin. Also, it looks like DupeFix loads its mixins in an unconventional way by adding dependent mods as coremods to be detected? I would assume then the issue is in fact due to the way DupeFix loads mixins, so this issue probably falls under #34.

Rongmario commented 1 year ago

I've added it to #34.