CleanroomMC / MixinBooter

Allows any mixins that work on mods to work effortlessly. With a single class and an annotation. On 1.12.2.
GNU Lesser General Public License v2.1
50 stars 17 forks source link

Can't use the other classloader with mixinbooter #54

Closed SettingDust closed 1 year ago

SettingDust commented 1 year ago

ConfigDecorators need Launch.loader for get mod id. I'm sideloading a mixin service in my own Class Loader for mixin some others. Can I disable it? Or remove the restrict since any classloader is able to adapt the logic?

Rongmario commented 1 year ago

It is meant for mod ids hence why it is pulling resource names from LaunchClassLoader. How will you be sideloading another mixin service? What is the usecase?

SettingDust commented 1 year ago

How will you be sideloading another mixin service?

Standalone class loader and a new MixinService

What is the usecase?

Mixin the bukkit plugins

Rongmario commented 1 year ago

I'll make the decorators non-static and decouple the FML elements then, thank you for bringing it up.

Noahfrechette commented 1 year ago

any news for fixing this?

Rongmario commented 1 year ago

It's being worked on here. The API should be finalizing in the next couple of days.

Rongmario commented 1 year ago

Should be implemented & fixed in 8.5.