russellmorley
commented
1 year ago WRT to the following @GeoDirk , @robertsonbrinker ,
"(I don't think this is related to changes in this branch but I noticed during this testing) There is a SourceLanguage corpus in Paratext called HEB/GRK. Currently it is all being treated as RTL because the first part (the OT) is Hebrew. The issue is that this corpus also includes the new testament in Greek which needs to be LTR."
I think this is an edge case and we should not modify our code to accommodate. Accommodating would be costly and convoluted.
robertsonbrinker
@GeoDirk Overall the branch looks great and the core functionality seems to work well. Here's a few things I noticed though:
SOLVED The Dashboard BCV control doesn't affect Paratext (this was an issue on Michael's branch that he is aware of. I don't know if a fix for this is going to make it into 0.4.5.0. I think he merged his branch into main and then main was probably merged into this branch).
When changing book quickly in CARS and landing on a book that was not selected and should be empty (in this case Obadiah), it shows text for the next book that was selected (in this case Micah). Changing books at a more reasonable pace solves the issue.
SOLVED You can't close the background task window while selecting books. It covers the screen so until it closes itself you can't select/unselect some of the books.
(I don't think this is related to changes in this branch but I noticed during this testing) There is a SourceLanguage corpus in Paratext called HEB/GRK. Currently it is all being treated as RTL because the first part (the OT) is Hebrew. The issue is that this corpus also includes the new testament in Greek which needs to be LTR.