search

ClearTK / cleartk

Machine learning components for Apache UIMA
http://cleartk.github.io/cleartk/
Other
130 stars 58 forks source link

Stanford core NLP jar location should be in a different directory #240

Closed bethard closed 9 years ago

bethard commented 9 years ago

Original issue 242 created by ClearTK on 2011-03-30T21:02:12.000Z:

Looking at the pom file for the new cleartk-syntax-stanford-corenlp, I see that the jar file should be located in the root directory for the project. This seems kind of messy. At the very least, I think that the directory structure created by the downloaded tarball should be preserved, but I think that perhaps there should be a 'lib' directory within projects that require separate downloads.

For our purposes I propose that the pom file include the following changes:

<edu.stanford.corenlp.path>${project.basedir}/lib/stanford-corenlp-2010-11-12</edu.stanford.corenlp.path> <edu.stanford.corenlp>${edu.stanford.corenlp.path}/stanford-corenlp-2010-11-12.jar</edu.stanford.corenlp> <edu.stanford.corenlp.models>${edu.stanford.corenlp.path}/stanford-corenlp-models-2010-11-06.jar</edu.stanford.corenlp.models>

This way I can download and keep things in one place, and if we bump the version of Stanford core NLP, I can blow away the directory instead of worrying about individual jar files.

bethard commented 9 years ago

Comment #1 originally posted by ClearTK on 2011-03-30T21:41:11.000Z:

Sure, this is fine with me.

Note though that you can already put it wherever you want as long as you specify -Dedustanford.corenlp=... and -Dedu.stanford.corenlp.models=...

bethard commented 9 years ago

Comment #2 originally posted by ClearTK on 2011-04-28T09:12:57.000Z:

Fixed by Lee in r2823 and added some info in the README in r 2841.

bethard commented 9 years ago

Comment #3 originally posted by ClearTK on 2011-04-30T03:55:05.000Z:

I want to point out that we have taken two different approaches for GPL code. For the Berkeley Parser wrapper I created a maven dependency and added it to our repo. So, if someone downloads that project and compiles it, then maven will automatically download the dependency. This may be blurring the lines of what is allowed by the license. But I think that it is still pretty clear that the non-gpl projects do not depend on any GPL code and that they can be compiled and distributed without any redistribution of GPL libraries.

bethard commented 9 years ago

Comment #4 originally posted by ClearTK on 2011-04-30T06:40:56.000Z:

I think the correct solution is actually for us to upload all our third-party dependencies to Maven central as described here:

https://docs.sonatype.org/display/Repository/Uploading+3rd-party+Artifacts+to+Maven+Central

Once we've done that, we can also deploy ClearTK to Maven central.